[webkit-reviews] review granted: [Bug 218058] Web Inspector: Network: background color of rows from previous session is wrong : [Attachment 412509] Web Inspector: Network: Fix background color of rows from previous session

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 10:49:37 PDT 2020


Devin Rousso <drousso at apple.com> has granted Federico Bucchi
<fbucchi at apple.com>'s request for review:
Bug 218058: Web Inspector: Network: background color of rows from previous
session is wrong
https://bugs.webkit.org/show_bug.cgi?id=218058

Attachment 412509: Web Inspector: Network: Fix background color of rows from
previous session

https://bugs.webkit.org/attachment.cgi?id=412509&action=review




--- Comment #3 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 412509
  --> https://bugs.webkit.org/attachment.cgi?id=412509
Web Inspector: Network: Fix background color of rows from previous session

View in context: https://bugs.webkit.org/attachment.cgi?id=412509&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:53
> +.network-table > .table li:not(.filler, .selected)
.cell:not(.current-session):not(.name) {

`:not(.name, .current-session)`?

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.css:61
> +.network-table > .table li:not(.filler) .cell.name:not(.current-session) > *
{

What about `.selected`?  I'm actually kinda OK with the idea of still having it
be slightly transparent when selected, but probably not this much.
```
    .network-table > .table li:not(.filler).selected
.cell.name:not(.current-session) > * {
	opacity: 0.8;
    }
```


More information about the webkit-reviews mailing list