[webkit-reviews] review denied: [Bug 218061] Web Inspector: Uncaught Exception: undefined is not an object (evaluating 'value.truncate') : [Attachment 412506] Fix Uncaught Exception: undefined is not an object (evaluating 'value.truncate')

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 28 10:23:23 PDT 2020


Devin Rousso <drousso at apple.com> has denied Federico Bucchi
<fbucchi at apple.com>'s request for review:
Bug 218061: Web Inspector: Uncaught Exception: undefined is not an object
(evaluating 'value.truncate')
https://bugs.webkit.org/show_bug.cgi?id=218061

Attachment 412506: Fix Uncaught Exception: undefined is not an object
(evaluating 'value.truncate')

https://bugs.webkit.org/attachment.cgi?id=412506&action=review




--- Comment #6 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 412506
  --> https://bugs.webkit.org/attachment.cgi?id=412506
Fix Uncaught Exception: undefined is not an object (evaluating
'value.truncate')

View in context: https://bugs.webkit.org/attachment.cgi?id=412506&action=review

> Source/WebInspectorUI/UserInterface/Models/DOMStorageObject.js:130
> -    itemUpdated(key, oldValue, newValue)
> +    itemUpdated(key, value)

This has to stay as it was before, as this is being called by
`WI.DOMStorageObserver.prototype.domStorageItemUpdated` which comes from the
protocol.

Basically, I think all you need to do is change `{key, oldValue, newValue}` to
`{key, value: newValue}`.


More information about the webkit-reviews mailing list