[webkit-reviews] review granted: [Bug 218073] DFGIntegerRangeOptimization is wrong for Upsilon (as 'shadow' nodes are not in SSA form) : [Attachment 412079] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 28 09:48:21 PDT 2020
Saam Barati <sbarati at apple.com> has granted Robin Morisset
<rmorisset at apple.com>'s request for review:
Bug 218073: DFGIntegerRangeOptimization is wrong for Upsilon (as 'shadow' nodes
are not in SSA form)
https://bugs.webkit.org/show_bug.cgi?id=218073
Attachment 412079: Patch
https://bugs.webkit.org/attachment.cgi?id=412079&action=review
--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 412079
--> https://bugs.webkit.org/attachment.cgi?id=412079
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412079&action=review
> Source/JavaScriptCore/dfg/DFGIntegerRangeOptimizationPhase.cpp:1532
> + unsigned i = 0, j = 0;
Nit: should be two lines def
More information about the webkit-reviews
mailing list