[webkit-reviews] review granted: [Bug 218289] [Cocoa] Remove soft linking of Contacts.framework : [Attachment 412533] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 218289: [Cocoa] Remove soft linking of Contacts.framework
https://bugs.webkit.org/show_bug.cgi?id=218289

Attachment 412533: Patch

https://bugs.webkit.org/attachment.cgi?id=412533&action=review




--- Comment #2 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 412533
  --> https://bugs.webkit.org/attachment.cgi?id=412533
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412533&action=review

r=me

> Source/WebKit/ChangeLog:4
> +	   [Cocoa] Remove soft linking of Contacts.framework
> +	   https://bugs.webkit.org/show_bug.cgi?id=218289

Nice!

> Source/WebKit/ChangeLog:9
> +	   Since Contacts.framework does not depend on WebKit and soft linking
is
> +	   discouraged, WebKit should link Contacts.framework normally.

This is a complex topic that few people understand, so I think a slightly more
detailed rationale is warranted in this ChangeLog.

Soft linking has a performance cost because it uses a function call (dlopen) at
runtime, and that requires running the linker at runtime, and running the
linker has a cost.

Weak linking avoids this performance cost because weak linking declares your
linkage at build time, which enables running the linker at build time or update
time or install time, avoiding the runtime cost.