[webkit-reviews] review requested: [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage : [Attachment 412513] Use symbols as identifiers, v8

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 216172: [JSC] Use symbols as identifiers for class fields computed names
storage
https://bugs.webkit.org/show_bug.cgi?id=216172

Attachment 412513: Use symbols as identifiers, v8

https://bugs.webkit.org/attachment.cgi?id=412513&action=review




--- Comment #21 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 412513

  --> https://bugs.webkit.org/attachment.cgi?id=412513&action=review

Use symbols as identifiers, v8

v8,
Hrm, what you suggest does not seem to work (new failures introduced); a bit
odd, since generator.shouldSetFunctionName() seems to be read-only.
I have rearranged the code a bit so that the boolean is used in both places and
we keep a single call to the function. Seems a bit neater to me, let me know if
that's fine.