[webkit-reviews] review granted: [Bug 218269] Use _CFURLConnectionSetFrameworkStubs for SecItemShim instead of DYLD_INTERPOSE on Apple Silicon Macs : [Attachment 412493] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 27 18:44:02 PDT 2020
Darin Adler <darin at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 218269: Use _CFURLConnectionSetFrameworkStubs for SecItemShim instead of
DYLD_INTERPOSE on Apple Silicon Macs
https://bugs.webkit.org/show_bug.cgi?id=218269
Attachment 412493: Patch
https://bugs.webkit.org/attachment.cgi?id=412493&action=review
--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 412493
--> https://bugs.webkit.org/attachment.cgi?id=412493
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412493&action=review
> Source/WebKit/Shared/mac/SecItemShim.cpp:146
> -#if PLATFORM(IOS_FAMILY)
> +#if PLATFORM(IOS_FAMILY) || (PLATFORM(MAC) && !CPU(X86_64))
How about this instead:
#if !CPU(X86_64)
It doesn’t seem like we need IOS_FAMILY vs. MAC here.
> Source/WebKit/Shared/mac/SecItemShim.cpp:158
> -#if PLATFORM(MAC)
> +#if PLATFORM(MAC) && CPU(X86_64)
How about this instead:
#if CPU(X86_64)
Or:
#else
It doesn’t seem like we need IOS_FAMILY vs. MAC here.
More information about the webkit-reviews
mailing list