[webkit-reviews] review denied: [Bug 218097] [macOS] Set preference for overridden languages in the WebContent process after entering the sandbox. : [Attachment 412438] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Per Arne Vollan
<pvollan at apple.com>'s request for review:
Bug 218097: [macOS] Set preference for overridden languages in the WebContent
process after entering the sandbox.
https://bugs.webkit.org/show_bug.cgi?id=218097

Attachment 412438: Patch

https://bugs.webkit.org/attachment.cgi?id=412438&action=review




--- Comment #12 from Alexey Proskuryakov <ap at webkit.org> ---
Comment on attachment 412438
  --> https://bugs.webkit.org/attachment.cgi?id=412438
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412438&action=review

> Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:39
> +    [[NSUserDefaults standardUserDefaults] setVolatileDomain:dict
forName:NSArgumentDomain];

This part is good I think.

> Tools/TestWebKitAPI/Tests/WebKit/OverrideAppleLanguagesPreference.mm:47
> +	   return [webView
stringByEvaluatingJavaScript:@"window.internals.userPreferredLanguages()[0]"];

This test does not verify the challenging side of the proposed change, which is
using correct localization resources. While I'm not 100% certain that it's
wrong, I recall that CFBundle was initialized right after calling
XPCServiceMain, so event handler is too late.

Please at least verify manually that the right localization is picked when
setting AppleLanguages in UI process.