[webkit-reviews] review granted: [Bug 203292] Accessory bar next/previous buttons do not work on inputs in shadow roots : [Attachment 412433] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Oct 27 10:18:47 PDT 2020
Ryosuke Niwa <rniwa at webkit.org> has granted Tetsuharu Ohzeki
<tetsuharu.ohzeki at gmail.com>'s request for review:
Bug 203292: Accessory bar next/previous buttons do not work on inputs in shadow
roots
https://bugs.webkit.org/show_bug.cgi?id=203292
Attachment 412433: Patch
https://bugs.webkit.org/attachment.cgi?id=412433&action=review
--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 412433
--> https://bugs.webkit.org/attachment.cgi?id=412433
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412433&action=review
New test looks good!
>
LayoutTests/fast/shadow-dom/ios/accessory-bar-work-on-input-with-tabindex-in-sh
adow-tree.html:206
> +} else {
> + document.getElementById('console').style.display = 'none';
> +}
Nit: no curly braces around a single line statement.
More information about the webkit-reviews
mailing list