[webkit-reviews] review requested: [Bug 216172] [JSC] Use symbols as identifiers for class fields computed names storage : [Attachment 412410] Use symbols as identifiers, v7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 27 05:02:40 PDT 2020


Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 216172: [JSC] Use symbols as identifiers for class fields computed names
storage
https://bugs.webkit.org/show_bug.cgi?id=216172

Attachment 412410: Use symbols as identifiers, v7

https://bugs.webkit.org/attachment.cgi?id=412410&action=review




--- Comment #18 from Xan Lopez <xan.lopez at gmail.com> ---
Created attachment 412410

  --> https://bugs.webkit.org/attachment.cgi?id=412410&action=review

Use symbols as identifiers, v7

v7,

rebased
fix a bug uncovered while rebasing static fields on top of this, we were using
the temporary private id for the computed property key as the function name in
some cases; will update test262 accordingly, since by chance this was not
tested properly in the instance test suite


More information about the webkit-reviews mailing list