[webkit-reviews] review granted: [Bug 217752] [WebXR] Move OpenXR calls off the main thread : [Attachment 412120] Patch for landing

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 217752: [WebXR] Move OpenXR calls off the main thread
https://bugs.webkit.org/show_bug.cgi?id=217752

Attachment 412120: Patch for landing

https://bugs.webkit.org/attachment.cgi?id=412120&action=review




--- Comment #22 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 412120
  --> https://bugs.webkit.org/attachment.cgi?id=412120
Patch for landing

LGTM.
The callback on constructor feels a bit weird but I guess this is fine.
Ideally, we would not need to hop to background thread, then hop to main thread
to create the device, then hop to background thread to initialise it, then hop
to main thread to continue processing.
We would do something like: hop to background thread, create/initialize device,
hop to main thread with the device (or a cross thread safe device structure),
create the vector and continue processing.
Might be worth trying to achieve this in a follow-up patch.