[webkit-reviews] review granted: [Bug 199866] Better cache our serialization of the outer TDZ environment when creating FunctionExecutables during bytecode generation : [Attachment 412330] same patch, but without huge test case
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 17:29:34 PDT 2020
Tadeu Zagallo <tzagallo at apple.com> has granted review:
Bug 199866: Better cache our serialization of the outer TDZ environment when
creating FunctionExecutables during bytecode generation
https://bugs.webkit.org/show_bug.cgi?id=199866
Attachment 412330: same patch, but without huge test case
https://bugs.webkit.org/attachment.cgi?id=412330&action=review
--- Comment #31 from Tadeu Zagallo <tzagallo at apple.com> ---
Comment on attachment 412330
--> https://bugs.webkit.org/attachment.cgi?id=412330
same patch, but without huge test case
View in context: https://bugs.webkit.org/attachment.cgi?id=412330&action=review
r=me
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:366
> + m_parentScopeTDZVariables = parentScopeTDZVariables;
This is not necessary, right? All this information is already in
m_cachedVariablesUnderTDZ
> Source/JavaScriptCore/bytecompiler/BytecodeGenerator.cpp:367
> + m_cachedVariablesUnderTDZ = m_parentScopeTDZVariables;
Could this be implemented as just a link to the parent environment?
More information about the webkit-reviews
mailing list