[webkit-reviews] review requested: [Bug 218206] [Mac] Audio and Video element creation up to 300x slower than other browsers : [Attachment 412353] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Oct 26 14:38:51 PDT 2020
Peng Liu <peng.liu6 at apple.com> has asked for review:
Bug 218206: [Mac] Audio and Video element creation up to 300x slower than other
browsers
https://bugs.webkit.org/show_bug.cgi?id=218206
Attachment 412353: Patch
https://bugs.webkit.org/attachment.cgi?id=412353&action=review
--- Comment #4 from Peng Liu <peng.liu6 at apple.com> ---
Comment on attachment 412353
--> https://bugs.webkit.org/attachment.cgi?id=412353
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412353&action=review
> Source/WebCore/platform/audio/mac/AudioSessionMac.mm:128
> + if (result)
Nit. Probably "if (result != noErr)" is better?
> Source/WebCore/platform/audio/mac/AudioSessionMac.mm:409
> + if (!result)
Nit. Probably "if (result == noErr)" is better?
More information about the webkit-reviews
mailing list