[webkit-reviews] review granted: [Bug 217960] Add test for cacheModelForMainBundle() in WebKitLegacy : [Attachment 412111] Patch v7

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 217960: Add test for cacheModelForMainBundle() in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217960

Attachment 412111: Patch v7

https://bugs.webkit.org/attachment.cgi?id=412111&action=review




--- Comment #27 from Darin Adler <darin at apple.com> ---
Comment on attachment 412111
  --> https://bugs.webkit.org/attachment.cgi?id=412111
Patch v7

View in context: https://bugs.webkit.org/attachment.cgi?id=412111&action=review

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:45
> +OTHER_CFLAGS = $(inherited) $(OTHER_CFLAGS_COCOA_TOUCH)
$(WK_CFLAGS_BUILD_FOR_TESTING_$(WK_BUILD_FOR_TESTING));

Could add a WK_CFLAGS_BUILD_FOR_TESTING without a suffix to make this and the
one other use simpler.

> Source/WebKitLegacy/mac/Configurations/WebKitLegacy.xcconfig:50
> +WK_CFLAGS_BUILD_FOR_TESTING_YES = -DENABLE_BUILD_FOR_TESTING=1;

No need for the "=1" here.