[webkit-reviews] review requested: [Bug 218177] REGRESSION (r268386): Flashes of inverted color when zooming the map on windy.com : [Attachment 412342] Patch

[bugzilla-daemon at webkit.org]

Myles C. Maxfield <mmaxfield at apple.com> has asked  for review:
Bug 218177: REGRESSION (r268386): Flashes of inverted color when zooming the
map on windy.com
https://bugs.webkit.org/show_bug.cgi?id=218177

Attachment 412342: Patch

https://bugs.webkit.org/attachment.cgi?id=412342&action=review




--- Comment #6 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 412342
  --> https://bugs.webkit.org/attachment.cgi?id=412342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412342&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:-337
> -	   m_webGLLayer = adoptNS([[WebGLLayer alloc] initWithClient:this
devicePixelRatio:attrs.devicePixelRatio contentsOpaque:!attrs.alpha]);

It looks like this eventually ends up calling
WebGLRenderingContextBase::didComposite() whenever the composition happens,
which seems to affect the web inspector and eventually will call
GraphicsContextGLOpenGL::prepareForDisplay(). This functions seems important,
and I don't see anything in the ChangeLog that explains why it's okay to stop
running that function for each composition.