[webkit-reviews] review granted: [Bug 218177] REGRESSION (r268386): Flashes of inverted color when zooming the map on windy.com : [Attachment 412342] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 26 12:00:57 PDT 2020


Dean Jackson <dino at apple.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 218177: REGRESSION (r268386): Flashes of inverted color when zooming the
map on windy.com
https://bugs.webkit.org/show_bug.cgi?id=218177

Attachment 412342: Patch

https://bugs.webkit.org/attachment.cgi?id=412342&action=review




--- Comment #5 from Dean Jackson <dino at apple.com> ---
Comment on attachment 412342
  --> https://bugs.webkit.org/attachment.cgi?id=412342
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412342&action=review

> LayoutTests/ChangeLog:14
> +	   Test case for WebGL which is drawn to a canvas that is not visible.
This should still
> +	   adhere to preserveDrawingBuffer == false contract of clearing the
drawing buffer
> +	   correctly.
> +
> +	   Case that failed at the time of writing was the case where after
draw, the element
> +	   would be removed by setting display:none.

Why is it failing on the iOS simulator?


More information about the webkit-reviews mailing list