[webkit-reviews] review granted: [Bug 218149] [Cocoa] Appending a new WebM init segment between Cluster elements throws an error : [Attachment 412237] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 218149: [Cocoa] Appending a new WebM init segment between Cluster elements
throws an error
https://bugs.webkit.org/show_bug.cgi?id=218149

Attachment 412237: Patch

https://bugs.webkit.org/attachment.cgi?id=412237&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 412237
  --> https://bugs.webkit.org/attachment.cgi?id=412237
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412237&action=review

r=me once the bots are happy

> Source/WebCore/platform/graphics/cocoa/SourceBufferParserWebM.cpp:537
> +	   INFO_LOG_IF_POSSIBLE(LOGIDENTIFIER, "received Ebml element while
parsing Segment element. Rewound reader and reset parser, retrying");

Maybe ALWAYS_LOG_IF_POSSIBLE?