[webkit-reviews] review granted: [Bug 218080] REGRESSION(r268615): certain animations break when moving from one to display to another or resizing the window : [Attachment 412183] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 218080: REGRESSION(r268615): certain animations break when moving from one
to display to another or resizing the window
https://bugs.webkit.org/show_bug.cgi?id=218080

Attachment 412183: Patch

https://bugs.webkit.org/attachment.cgi?id=412183&action=review




--- Comment #6 from Dean Jackson <dino at apple.com> ---
Comment on attachment 412183
  --> https://bugs.webkit.org/attachment.cgi?id=412183
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412183&action=review

> Source/WebCore/style/StyleTreeResolver.cpp:352
> +	   auto previousLastStyleChangeEventStyle =
styleable.lastStyleChangeEventStyle() ?
RenderStyle::clonePtr(*styleable.lastStyleChangeEventStyle()) :
RenderStyle::createPtr();

Do you need to clone/copy? Does applyKeyframeEffects mutate the style?