[webkit-reviews] review granted: [Bug 217880] [Testing] Convert DumpRenderTree to use generated test header options : [Attachment 412189] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 217880: [Testing] Convert DumpRenderTree to use generated test header
options
https://bugs.webkit.org/show_bug.cgi?id=217880

Attachment 412189: Patch

https://bugs.webkit.org/attachment.cgi?id=412189&action=review




--- Comment #33 from Darin Adler <darin at apple.com> ---
Comment on attachment 412189
  --> https://bugs.webkit.org/attachment.cgi?id=412189
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412189&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:2992
>  @end
>  
> +
> + at implementation WebPreferences (WebPrivateTesting)

Maybe just one blank line here?

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3004
> +    RetainPtr<CFHTTPCookieStorageRef> cookieStorage =
NetworkStorageSessionMap::defaultStorageSession().cookieStorage();

auto

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:3005
> +    ASSERT(cookieStorage); // Will fail when
NetworkStorageSessionMap::switchToNewTestingSession() was not called
beforehand.

Maybe RELEASE_ASSERT? Certainly harmless to do that, and can’t say that about
all ASSERT.

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:306
> + at interface WebPreferences (WebPrivateTesting)

I suggest either a blank line after @interface or no blank line before @end.