[webkit-reviews] review granted: [Bug 218123] Rename slave to worker in webkitpy : [Attachment 412177] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Oct 23 09:08:16 PDT 2020

Jonathan Bedard <jbedard at apple.com> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 218123: Rename slave to worker in webkitpy

Attachment 412177: Patch


--- Comment #2 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 412177
  --> https://bugs.webkit.org/attachment.cgi?id=412177

View in context: https://bugs.webkit.org/attachment.cgi?id=412177&action=review

> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:578
> +	   build_worker = self._options.build_slave

We will need to expose a "build_worker" option, change all our buildbot
invocations, and then remove the "build_slave" option to totally get rid of
this. (not particularly difficult, just going to take a few patches and a few
buildbot restarts)

More information about the webkit-reviews mailing list