[webkit-reviews] review granted: [Bug 217737] Twitter Photo gallery incorrectly rendered after opening another modal : [Attachment 412124] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 22 14:49:01 PDT 2020


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 217737: Twitter Photo gallery incorrectly rendered after opening another
modal
https://bugs.webkit.org/show_bug.cgi?id=217737

Attachment 412124: Patch

https://bugs.webkit.org/attachment.cgi?id=412124&action=review




--- Comment #14 from zalan <zalan at apple.com> ---
Comment on attachment 412124
  --> https://bugs.webkit.org/attachment.cgi?id=412124
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412124&action=review

nice cleanup on bool setMasksToBoundsRect()

> Source/WebCore/rendering/RenderLayerBacking.cpp:1325
> +	   auto computeMasksToBoundsRect = [&]() {

[&] should do

> Source/WebCore/rendering/RenderLayerBacking.cpp:2219
> +    auto needsClipMaskLayer = [&]() {

Same here


More information about the webkit-reviews mailing list