[webkit-reviews] review granted: [Bug 218082] [webkitpy] Rename slave to worker in perftestsrunner : [Attachment 412109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 22 10:52:52 PDT 2020


Ryosuke Niwa <rniwa at webkit.org> has granted Aakash Jain
<aakash_jain at apple.com>'s request for review:
Bug 218082: [webkitpy] Rename slave to worker in perftestsrunner
https://bugs.webkit.org/show_bug.cgi?id=218082

Attachment 412109: Patch

https://bugs.webkit.org/attachment.cgi?id=412109&action=review




--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 412109
  --> https://bugs.webkit.org/attachment.cgi?id=412109
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412109&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:178
> +	   # TODO: remove this test and the corresponding parameter after all
instances of this deprecated parameter have been removed

Use FIXME instead.


More information about the webkit-reviews mailing list