[webkit-reviews] review granted: [Bug 218064] Web Inspector: REGRESSION(r266074): Sources: icon for non-JavaScript breakpoints doesn't change when breakpoints are globally disabled : [Attachment 412055] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Oct 22 09:49:24 PDT 2020
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 218064: Web Inspector: REGRESSION(r266074): Sources: icon for
non-JavaScript breakpoints doesn't change when breakpoints are globally
disabled
https://bugs.webkit.org/show_bug.cgi?id=218064
Attachment 412055: Patch
https://bugs.webkit.org/attachment.cgi?id=412055&action=review
--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 412055
--> https://bugs.webkit.org/attachment.cgi?id=412055
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=412055&action=review
r=me
> Source/WebInspectorUI/ChangeLog:12
> + Add `get resolved` to the base class based on
`WI.debuggerManager.breakpointsEnabled`. Use
What causes the entire sidebar to update status when the global state changes?
More information about the webkit-reviews
mailing list