[webkit-reviews] review granted: [Bug 218060] [LFC][IFC] Handle line box sizing quirks at the line box level : [Attachment 412058] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted zalan <zalan at apple.com>'s request
for review:
Bug 218060: [LFC][IFC] Handle line box sizing quirks at the line box level
https://bugs.webkit.org/show_bug.cgi?id=218060

Attachment 412058: Patch

https://bugs.webkit.org/attachment.cgi?id=412058&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 412058
  --> https://bugs.webkit.org/attachment.cgi?id=412058
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412058&action=review

>
Source/WebCore/layout/inlineformatting/InlineFormattingContextGeometry.cpp:359
> +	       if (inlineLevelBox.isEmpty())
> +		   return false;
> +	       return quirks.shouldInlineLevelBoxStretchLineBox(lineBox,
inlineLevelBox);

maybe the inlineLevelBox.isEmpty() test could go to the quirk too so the lambda
would go away?