[webkit-reviews] review granted: [Bug 218020] Stop gap patch fix for regression in r267329. : [Attachment 412039] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 16:04:39 PDT 2020

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 218020: Stop gap patch fix for regression in r267329.

Attachment 412039: Patch


--- Comment #9 from Darin Adler <darin at apple.com> ---
Comment on attachment 412039
  --> https://bugs.webkit.org/attachment.cgi?id=412039

View in context: https://bugs.webkit.org/attachment.cgi?id=412039&action=review

> Source/WebCore/editing/VisibleSelection.cpp:389
> +    bool shouldUpdateAnchor = false; // Set to false because of
<rdar://problem/69542459>. Can be returned to original logic when this problem
is fully fixed.

Probably more kind to open source contributors to cite
https://bugs.webkit.org/show_bug.cgi?id=218020 instead of rdar, but clear
enough either way. I promise to remove this comment some day either way.

More information about the webkit-reviews mailing list