[webkit-reviews] review granted: [Bug 218004] [iOS] Prevent presentation of input peripherals when focusing form controls with a validation message : [Attachment 411939] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 218004: [iOS] Prevent presentation of input peripherals when focusing form
controls with a validation message
https://bugs.webkit.org/show_bug.cgi?id=218004

Attachment 411939: Patch

https://bugs.webkit.org/attachment.cgi?id=411939&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 411939
  --> https://bugs.webkit.org/attachment.cgi?id=411939
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411939&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:537
> +    m_willShowValidationMessage = true;

Is it possible for this to be called twice in the same runloop? If so, we
should consider making this a counter and incrementing/decrementing it instead
(and then `HTMLFormControlElement::willShowValidationMessage` would return true
if the count is nonzero).