[webkit-reviews] review granted: [Bug 216426] Let webkitDisplayingFullscreen() return true when a video element’s fullscreen mode is not VideoFullscreenModeNone : [Attachment 411804] Rebase the patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Peng Liu <peng.liu6 at apple.com>'s
request for review:
Bug 216426: Let webkitDisplayingFullscreen() return true when a video element’s
fullscreen mode is not VideoFullscreenModeNone
https://bugs.webkit.org/show_bug.cgi?id=216426

Attachment 411804: Rebase the patch

https://bugs.webkit.org/attachment.cgi?id=411804&action=review




--- Comment #8 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 411804
  --> https://bugs.webkit.org/attachment.cgi?id=411804
Rebase the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411804&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:5936
> +		   if (mode == VideoFullscreenModeStandard)
> +		       m_waitingToEnterFullscreen = true;

It looks like this is the meat of the change. That we only set
m_waitingToEnterFullscreen if we're entering "standard" fullscreen.

> Source/WebCore/html/HTMLMediaElement.cpp:6016
> +	       setFullscreenMode(VideoFullscreenModeNone);

And this is the second functional part of the change, that when
exitFullscreen() is called, we set the fullscreenMode to "none" if the old mode
was "standard".

This all looks good to me; glad we can write more careful tests through
Internals now.