[webkit-reviews] review granted: [Bug 217960] Add test for cacheModelForMainBundle() in WebKitLegacy : [Attachment 412027] Patch v5

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 217960: Add test for cacheModelForMainBundle() in WebKitLegacy
https://bugs.webkit.org/show_bug.cgi?id=217960

Attachment 412027: Patch v5

https://bugs.webkit.org/attachment.cgi?id=412027&action=review




--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 412027
  --> https://bugs.webkit.org/attachment.cgi?id=412027
Patch v5

View in context: https://bugs.webkit.org/attachment.cgi?id=412027&action=review

> Source/WebKitLegacy/mac/InstallAPIExportsForTesting.h:31
> +WebCacheModel WebPreferencesCacheModelForMainBundle(NSString
*bundleIdentifier);

Not sure I’d put the name "InstallAPIExports" into this header’s name. Maybe
just TestingFunctions.h?

> Source/WebKitLegacy/mac/WebView/WebPreferences.mm:95
> +WTF_EXTERN_C_BEGIN
> +// See also mac/InstallAPIExportsForTesting.h.
> +WebCacheModel WebPreferencesCacheModelForMainBundle(NSString
*bundleIdentifier);
> +WTF_EXTERN_C_END

Seems like we’d just include the InstallAPIExportsForTesting.h header instead
of doing this.