[webkit-reviews] review granted: [Bug 218045] Add addOutput() / removeOutput() utility functions to AudioSummingJunction : [Attachment 412018] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 13:22:42 PDT 2020


Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 218045: Add addOutput() / removeOutput() utility functions to
AudioSummingJunction
https://bugs.webkit.org/show_bug.cgi?id=218045

Attachment 412018: Patch

https://bugs.webkit.org/attachment.cgi?id=412018&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 412018
  --> https://bugs.webkit.org/attachment.cgi?id=412018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412018&action=review

> Source/WebCore/Modules/webaudio/AudioNodeInput.cpp:60
> +    auto addPotentiallyDisabledOutput = [this](AudioNodeOutput& output) {
> +	   if (output.isEnabled())
> +	       return addOutput(output);
> +	   return m_disabledOutputs.add(&output).isNewEntry;
> +    };

Is it not necessary to mark rendering state as dirty when a disabled output is
connected?


More information about the webkit-reviews mailing list