[webkit-reviews] review granted: [Bug 218020] Stop gap patch fix for regression in r267329. : [Attachment 412019] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 218020: Stop gap patch fix for regression in r267329.
https://bugs.webkit.org/show_bug.cgi?id=218020

Attachment 412019: Patch

https://bugs.webkit.org/attachment.cgi?id=412019&action=review




--- Comment #6 from Darin Adler <darin at apple.com> ---
Comment on attachment 412019
  --> https://bugs.webkit.org/attachment.cgi?id=412019
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=412019&action=review

Looks good. I really appreciate having the test, which I will keep working
and/or refine as I return to the Selection API work.

> Source/WebCore/editing/VisibleSelection.cpp:390
> -    bool shouldUpdateAnchor = m_start != startBeforeAdjustments;
> -    bool shouldUpdateFocus = m_end != endBeforeAdjustments;
> +    bool shouldUpdateAnchor = false;
> +    bool shouldUpdateFocus = false;

Might be good to leave a comment behind here. The fact that these are always
false makes the code peculiar for now, but makes sense if you know we intend to
change it later.