[webkit-reviews] review granted: [Bug 217752] [WebXR] Move OpenXR calls off the main thread : [Attachment 411967] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 06:18:37 PDT 2020

youenn fablet <youennf at gmail.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 217752: [WebXR] Move OpenXR calls off the main thread

Attachment 411967: Patch


--- Comment #16 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 411967
  --> https://bugs.webkit.org/attachment.cgi?id=411967

View in context: https://bugs.webkit.org/attachment.cgi?id=411967&action=review

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:250
> +	       m_immersiveXRDevices.clear();

clear not needed.

> Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:255
> +	       }));

It might read better like this:
prepareDevice(systemId, m_impl->xrInstance(), m_impl->queue(), [...](auto&&
device) {
    m_immersiveXRDevices = DeviceList::from(WTFMove(device));
It seems to me though that if m_immersiveXRDevices already has a device which
is matching systemId and instance, we might just be able to return
m_immersiveXRDevices directly?

More information about the webkit-reviews mailing list