[webkit-reviews] review granted: [Bug 217974] [GStreamer] Create video sink only for video player : [Attachment 411888] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 21 02:48:06 PDT 2020


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 217974: [GStreamer] Create video sink only for video player
https://bugs.webkit.org/show_bug.cgi?id=217974

Attachment 411888: Patch

https://bugs.webkit.org/attachment.cgi?id=411888&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 411888
  --> https://bugs.webkit.org/attachment.cgi?id=411888
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411888&action=review

> Source/WebCore/platform/graphics/gstreamer/GStreamerCommon.cpp:320
> -	   gst_element_register(0, "webkitglvideosink", GST_RANK_PRIMARY,
WEBKIT_TYPE_GL_VIDEO_SINK);
> +	   gst_element_register(0, "webkitglvideosink", GST_RANK_NONE,
WEBKIT_TYPE_GL_VIDEO_SINK);

Why do you need this?

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2732
> +    GST_INFO("Creating pipeline for %s player", m_player->isVideoPlayer() ?
"video":"audio");

Nit: spaces around :


More information about the webkit-reviews mailing list