[webkit-reviews] review requested: [Bug 214861] [JSC] support op_get_private_name in DFG and FTL : [Attachment 411901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 12:59:07 PDT 2020


Caitlin Potter (:caitp) <caitp at igalia.com> has asked  for review:
Bug 214861: [JSC] support op_get_private_name in DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=214861

Attachment 411901: Patch

https://bugs.webkit.org/attachment.cgi?id=411901&action=review




--- Comment #41 from Caitlin Potter (:caitp) <caitp at igalia.com> ---
Created attachment 411901

  --> https://bugs.webkit.org/attachment.cgi?id=411901&action=review

Patch

This accesses the child edges in a consistent way everywhere --- and adds a
little bit of complexity by using a SpeculateCellOperand when we have a
CellUse. Cleans some other things up a bit, adds some asserts, and is verified
to not allocate a long-lasting tag operand on 32bit when speculate Cell for
base


More information about the webkit-reviews mailing list