[webkit-reviews] review denied: [Bug 217951] WebDriver: sequence of char key press is not supported : [Attachment 411859] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 217951: WebDriver: sequence of char key press is not supported
https://bugs.webkit.org/show_bug.cgi?id=217951

Attachment 411859: Patch

https://bugs.webkit.org/attachment.cgi?id=411859&action=review




--- Comment #2 from Brian Burg <bburg at apple.com> ---
Comment on attachment 411859
  --> https://bugs.webkit.org/attachment.cgi?id=411859
Patch

r- due to failing build.

Overall this looks like an improvement. I am worried about iteration order of
the char keys being undefined and causing flaky test failures. Can we use
ListHashSet to avoid this?