[webkit-reviews] review granted: [Bug 217223] WebDriver: start a https server too for tests : [Attachment 411849] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 20 03:51:36 PDT 2020

Adrian Perez <aperez at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 217223: WebDriver: start a https server too for tests

Attachment 411849: Patch


--- Comment #3 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 411849
  --> https://bugs.webkit.org/attachment.cgi?id=411849

View in context: https://bugs.webkit.org/attachment.cgi?id=411849&action=review

> Tools/ChangeLog:9
> +	   Handle HTTPS configuration in WebDriver WTP server.

Typo: WTP → WPT.

> Tools/Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:98
> +	   config['doc_root'] = doc_root

Much nicer to modify the data structure than blindly replacing %DOC_ROOT% =)

More information about the webkit-reviews mailing list