[webkit-reviews] review granted: [Bug 216171] [GStreamer] REGRESSION(r266559): imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-interface/destination.html is failing : [Attachment 411850] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 216171: [GStreamer] REGRESSION(r266559):
imported/w3c/web-platform-tests/webaudio/the-audio-api/the-destinationnode-inte
rface/destination.html is failing
https://bugs.webkit.org/show_bug.cgi?id=216171

Attachment 411850: Patch

https://bugs.webkit.org/attachment.cgi?id=411850&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 411850
  --> https://bugs.webkit.org/attachment.cgi?id=411850
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411850&action=review

> Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.cpp:103
> +	   WTFLogAlways("AudioDestination::create(%u, %u, %f) - unhandled input
channels", numberOfInputChannels, numberOfOutputChannels, sampleRate);

As Peng Liu asked, is the change to always intentional?