[webkit-reviews] review granted: [Bug 217924] [results.webkit.org] Refresh S3 context when token expires : [Attachment 411806] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted  review:
Bug 217924: [results.webkit.org] Refresh S3 context when token expires
https://bugs.webkit.org/show_bug.cgi?id=217924

Attachment 411806: Patch

https://bugs.webkit.org/attachment.cgi?id=411806&action=review




--- Comment #6 from dewei_zhu at apple.com ---
Comment on attachment 411806
  --> https://bugs.webkit.org/attachment.cgi?id=411806
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411806&action=review

>>> Tools/Scripts/libraries/resultsdbpy/resultsdbpy/model/s3_archiver.py:92
>>> +	     if self._cached_token != self.credentials.aws_session_token:
>> 
>> Maybe adding a null check here or assert on constructor to make sure
self.credentials is not None?
> 
> I can put this check in the __init__, because (although the review hides it),
line 63 will raise an exception first.

Got it.