[webkit-reviews] review granted: [Bug 217928] %TypedArray%#sort helper functions should be globalPrivate : [Attachment 411810] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 217928: %TypedArray%#sort helper functions should be globalPrivate
https://bugs.webkit.org/show_bug.cgi?id=217928

Attachment 411810: Patch

https://bugs.webkit.org/attachment.cgi?id=411810&action=review




--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 411810
  --> https://bugs.webkit.org/attachment.cgi?id=411810
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411810&action=review

r=me

> Source/JavaScriptCore/builtins/TypedArrayPrototype.js:212
> +    var buffer = [];
> +    buffer.length = valueCount;

Use `var buffer = @newArrayWithSize(valueCount)`.