[webkit-reviews] review granted: [Bug 217425] REGRESSION(r268115) [GTK] Build failures with GCC 7 (Ubuntu 18.04) and GCC 8 (Debian Buster) : [Attachment 411801] Patch with only compile check

[bugzilla-daemon at webkit.org]

Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Lauro Moura
<lmoura at igalia.com>'s request for review:
Bug 217425: REGRESSION(r268115) [GTK] Build failures with GCC 7 (Ubuntu 18.04)
and GCC 8 (Debian Buster)
https://bugs.webkit.org/show_bug.cgi?id=217425

Attachment 411801: Patch with only compile check

https://bugs.webkit.org/attachment.cgi?id=411801&action=review




--- Comment #14 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 411801
  --> https://bugs.webkit.org/attachment.cgi?id=411801
Patch with only compile check

View in context: https://bugs.webkit.org/attachment.cgi?id=411801&action=review

> Tools/WebKitTestRunner/CMakeLists.txt:33
> +	   set(WebKitTestRunner_LIBRARIES
> +	       ${WebKitTestRunner_LIBRARIES}
> +	       stdc++fs

perhaps is maybe better to use here:

list(APPEND WebKitTestRunner_LIBRARIES
stdc++fs
)