[webkit-reviews] review granted: [Bug 217635] Elements in Shadow DOM are wrongly marked as stale by the WebDriver : [Attachment 411275] Patch

[bugzilla-daemon at webkit.org]

Brian Burg <bburg at apple.com> has granted linkgoron
<webkitbugzilla at steakexchange.com>'s request for review:
Bug 217635: Elements in Shadow DOM are wrongly marked as stale by the WebDriver
https://bugs.webkit.org/show_bug.cgi?id=217635

Attachment 411275: Patch

https://bugs.webkit.org/attachment.cgi?id=411275&action=review




--- Comment #7 from Brian Burg <bburg at apple.com> ---
Comment on attachment 411275
  --> https://bugs.webkit.org/attachment.cgi?id=411275
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411275&action=review

r=me

Please fix typos in the Changelog and I'll set cq+.

> Source/WebDriver/ChangeLog:9
> +	   instead of document.contains which doesnt work for elements in
Shadow DOM

Nit: 'doesn't'
Nit: ending period.

> Source/WebKit/ChangeLog:9
> +	   instead of declaring them as not interactable

Nit: ending period.