[webkit-reviews] review granted: [Bug 217918] Tweak WebPreferences*.yaml "exposed" key to only indicate that the key should not be changeable by the frontend : [Attachment 411779] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 217918: Tweak WebPreferences*.yaml "exposed" key to only indicate that the
key should not be changeable by the frontend
https://bugs.webkit.org/show_bug.cgi?id=217918

Attachment 411779: Patch

https://bugs.webkit.org/attachment.cgi?id=411779&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 411779
  --> https://bugs.webkit.org/attachment.cgi?id=411779
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411779&action=review

r=me assuming it builds and passes tests

> Source/WTF/ChangeLog:3
> +	   Tweak WebPreferences*.yaml "exposed" key to only indicate that the
key should not be changeable by the frontend

This is important for the non-testing API and SPI, and the features we expose
for tweaking in Safari Technology Preview. But for *testing* interfaces, do we
really need to carefully control what is exposed? Why not expose it all for
testing? I suppose there could be a downside if someone unwisely tweaks a
setting in a test and we don’t notice that? I can’t quite tell our intent about
that, though. Maybe some documentation overview could help make that intent
clear?