[webkit-reviews] review granted: [Bug 217910] Import speech tests from WPT : [Attachment 411763] Patch

Mon Oct 19 11:17:41 PDT 2020

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 217910: Import speech tests from WPT
https://bugs.webkit.org/show_bug.cgi?id=217910

Attachment 411763: Patch

https://bugs.webkit.org/attachment.cgi?id=411763&action=review

--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 411763
  --> https://bugs.webkit.org/attachment.cgi?id=411763
Patch

r=me.
Would be good to be able to run the tests that do not crash or time out, even
if they fail.

View in context: https://bugs.webkit.org/attachment.cgi?id=411763&action=review

> LayoutTests/TestExpectations:176
> +imported/w3c/web-platform-tests/speech-api/ [ Skip ]

Can we enable them in some cocoa TestExpectations?

>
LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechRecognition-onresu
lt-manual.https.html:1
> +<!DOCTYPE html>

Probably not needed.
The importer is expected to not import these, maybe the https prefix is messing
things up.

>
LayoutTests/imported/w3c/web-platform-tests/speech-api/SpeechSynthesis-speak-ow
nership.html:22
> +}, 'Using the same SpeechSynthesisUtterance with two SpeechSynthesis
instances');

Can we check in some expected.txt files?