[webkit-reviews] review granted: [Bug 217912] Introduce execStateFromWorkerOrWorletGlobalScope() : [Attachment 411765] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 217912: Introduce execStateFromWorkerOrWorletGlobalScope()
https://bugs.webkit.org/show_bug.cgi?id=217912

Attachment 411765: Patch

https://bugs.webkit.org/attachment.cgi?id=411765&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 411765
  --> https://bugs.webkit.org/attachment.cgi?id=411765
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411765&action=review

Looks great, r=me assuming all tests pass.

> Source/WebCore/ChangeLog:10
> +	   Introduce execStateFromWorkerOrWorletGlobalScope() to replace
existing execStateFromWorkerGlobalScope()
> +	   and execStateFromWorkletGlobalScope(). This is a first step to
promote code sharing. Ideally, code
> +	   would not have to differentiate workers from worklets as much as
possible.

I don’t think we call this "exec state" any more, we call it "JavaScript global
object". Is there some way to take advantage of that? Maybe all of these
functions should get new names.