[webkit-reviews] review granted: [Bug 217811] WebRTC VP9 Decoder should be able to use VTB : [Attachment 411742] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 217811: WebRTC VP9 Decoder should be able to use VTB
https://bugs.webkit.org/show_bug.cgi?id=217811

Attachment 411742: Patch

https://bugs.webkit.org/attachment.cgi?id=411742&action=review




--- Comment #8 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 411742
  --> https://bugs.webkit.org/attachment.cgi?id=411742
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411742&action=review

> Source/ThirdParty/libwebrtc/Source/webrtc/sdk/WebKit/WebKitVP9Decoder.cpp:81
> +    64, //sizeof(WebKitVP9Decoder),

Is this necessary?

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVi
deoDecoderVTBVP9.mm:65
> +    return nullptr;

Is it worth logging here?

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVi
deoDecoderVTBVP9.mm:70
> +    return nullptr;

Ditto