[webkit-reviews] review granted: [Bug 217336] [macOS] Add XPC endpoint entitlement for the WebContent development process : [Attachment 410564] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Per Arne Vollan <pvollan at apple.com>'s
request for review:
Bug 217336: [macOS] Add XPC endpoint entitlement for the WebContent development
process
https://bugs.webkit.org/show_bug.cgi?id=217336

Attachment 410564: Patch

https://bugs.webkit.org/attachment.cgi?id=410564&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 410564
  --> https://bugs.webkit.org/attachment.cgi?id=410564
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=410564&action=review

> Source/WebKit/ChangeLog:10
> +	   The WebContent process has the entitlement
'com.apple.private.webkit.use-xpc-endpoint',
> +	   which is not present in the development version.

I’ll take your word for it that this is a good change.

But I don’t understand what you are saying here with that sentence. You say the
process "has the entitlement", but how does it get it? You say it "is not
present in the development version". Is that a statement of what’s wrong and
what you are fixing, and hence no longer true? Or does it mean something else.

What I see in the patch is two changes:

1) Only add use-xpc-endpoint for macOS 11.0 and newer.
2) Add use-xpc-endpoint even when WK_USE_RESTRICTED_ENTITLEMENTS is NO.

I can’t make the connection between this and "the development version" and "has
the entitlement" comment above.