[webkit-reviews] review granted: [Bug 217879] test262: test/language/expressions/conditional/in-branch-1.js : [Attachment 411692] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted Mark Cohen <m at mpc.sh>'s
request for review:
Bug 217879: test262: test/language/expressions/conditional/in-branch-1.js
https://bugs.webkit.org/show_bug.cgi?id=217879

Attachment 411692: Patch

https://bugs.webkit.org/attachment.cgi?id=411692&action=review




--- Comment #4 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 411692
  --> https://bugs.webkit.org/attachment.cgi?id=411692
Patch

That's a great first patch, Mark!

r=me with 2 comments:

1. Let's AllowInOverride instead.
2. Please remove now passing test from JSTests/test262/expectations.yaml.