[webkit-reviews] review granted: [Bug 217877] Convert preferences in WebPreferencesPrivate.h to use @property syntax to make them more manageable : [Attachment 411673] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Sam Weinig
<sam at webkit.org>'s request for review:
Bug 217877: Convert preferences in WebPreferencesPrivate.h to use @property
syntax to make them more manageable
https://bugs.webkit.org/show_bug.cgi?id=217877

Attachment 411673: Patch

https://bugs.webkit.org/attachment.cgi?id=411673&action=review




--- Comment #4 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 411673
  --> https://bugs.webkit.org/attachment.cgi?id=411673
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411673&action=review

> Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h:259
> + at property (nonatomic, retain) NSArray<NSString *>
*additionalSupportedImageTypes; // additionalSupportedImageTypes is an array of
image UTIs.

Is 'retain' the behavior of the existing code, or should this be 'copy'?