[webkit-reviews] review granted: [Bug 217854] Ensure %TypedArray% essential internal methods adhere to spec : [Attachment 411639] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 217854: Ensure %TypedArray% essential internal methods adhere to spec
https://bugs.webkit.org/show_bug.cgi?id=217854

Attachment 411639: Patch

https://bugs.webkit.org/attachment.cgi?id=411639&action=review




--- Comment #5 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 411639
  --> https://bugs.webkit.org/attachment.cgi?id=411639
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411639&action=review

r=me with LayoutTests updates.
And can you check the correct semantics is right in LLInt, JIT, etc.'s
TypedArray fast paths?

>> JSTests/test262/expectations.yaml:1266
>> +  strict mode: 'Test262Error: Expected a TypeError but got a Test262Error
(Testing with Float64Array.)'
> 
> What is the reason of getting these new errors?

Discussed with Ross offline. They are test262's bugs and tracked right now
https://github.com/tc39/test262/pull/2833.