[webkit-reviews] review granted: [Bug 217843] [WebAuthn] Add an experimental feature flag: WebAuthenticationModernEnabled : [Attachment 411627] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 217843: [WebAuthn] Add an experimental feature flag:
WebAuthenticationModernEnabled
https://bugs.webkit.org/show_bug.cgi?id=217843

Attachment 411627: Patch

https://bugs.webkit.org/attachment.cgi?id=411627&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 411627
  --> https://bugs.webkit.org/attachment.cgi?id=411627
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411627&action=review

r=me

> Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml:870
> +# FIXME: Is this implemented for WebKitLegacy? If not, this should be
excluded from WebKitLegacy entirely.

This doesn't work in WKL. But I don't know how you exclude something in this
YAML markup.