[webkit-reviews] review granted: [Bug 217559] [WebAuthn] Implement a dummy WebAuthnProcess : [Attachment 411396] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 217559: [WebAuthn] Implement a dummy WebAuthnProcess
https://bugs.webkit.org/show_bug.cgi?id=217559

Attachment 411396: Patch

https://bugs.webkit.org/attachment.cgi?id=411396&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 411396
  --> https://bugs.webkit.org/attachment.cgi?id=411396
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411396&action=review

You should have Chris Dumez take a look at the process assertion bits, but this
seems to be correct as far as I can tell. You should also file a bug to add
relevant entitlements to the new service once you start moving calls to USB/NFC
things into this new code path.

> Source/WebKit/ChangeLog:25
> +	   This patch therefore focues on making the WebAuthn process happen
and removes the WebAuthn daemon.

focus

> Source/WebKit/ChangeLog:45
> +	   Paperwork for introudcing the new WebAuthn process. Mostly copied
from GPU process.

introducing

> Source/WebKit/ChangeLog:125
> +	   Paperwork for introudcing the new WebAuthn process. Mostly copied
from GPU process.

introducing

> Source/WebKit/ChangeLog:128
> +	   The sandbox profile is originally from the GPU Process with IOKit
related rules removed. Will tighten it again after the process is functional
properly.

"process is fully functional"

> Source/WebKit/ChangeLog:153
> +	   Paperwork for introudcing the new WebAuthn process. Mostly copied
from GPU process.

introducing

> Source/WebCore/en.lproj/Localizable.strings:49
> +/* visible name of the GPU process. The argument is the application name. */

This isn't the GPU Process. This is the Web Authentication process!

> Source/WebKit/UIProcess/Launcher/mac/ProcessLauncherMac.mm:81
> +    // On Mac, leak a boost onto the NetworkProcess, GPUProcess and
WebAuthnProcess.

Please use the "Oxford Comma":	"NetworkProcess, GPUProcess, and
WebAuthnProcess."