[webkit-reviews] review granted: [Bug 217803] Move even more AudioContext-specific logic out of BaseAudioContext : [Attachment 411526] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 217803: Move even more AudioContext-specific logic out of BaseAudioContext
https://bugs.webkit.org/show_bug.cgi?id=217803

Attachment 411526: Patch

https://bugs.webkit.org/attachment.cgi?id=411526&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 411526
  --> https://bugs.webkit.org/attachment.cgi?id=411526
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=411526&action=review

> Source/WebCore/Modules/webaudio/AudioContext.cpp:390
> +	       RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Suspending
playback after going to the background");

Any reason to not use `ALWAYS_LOG(LOGIDENTIFIER, ...)` so the output is in the
same format as the rest of the logging from this class?

> Source/WebCore/Modules/webaudio/AudioContext.cpp:395
> +	       RELEASE_LOG_IF_ALLOWED("visibilityStateChanged() Resuming
playback after entering foreground");

Ditto.